Skip to content

OSASINFRA-3600: CARRY: OpenShift manifests & Makefile targets #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Feb 12, 2025
Merged

OSASINFRA-3600: CARRY: OpenShift manifests & Makefile targets #9

openshift-merge-bot merged 1 commit into from
Feb 12, 2025

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Feb 6, 2025 •
edited
Loading

Co-Authored-By: @mdbooth

@openshift-ci openshift-ci bot requested review from dkokkino and mandre February 6, 2025 17:43
@EmilienM EmilienM force-pushed the openshift branch 4 times, most recently from 7d95175 to b080d54 Compare February 6, 2025 20:05
@EmilienM EmilienM changed the title CARRY: OpenStack manifests OSASINFRA-3601: CARRY: OpenStack manifests Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025 •
edited by openshift-ci bot
Loading

@EmilienM: This pull request references OSASINFRA-3601 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2025
@EmilienM EmilienM changed the title OSASINFRA-3601: CARRY: OpenStack manifests OSASINFRA-3600: CARRY: OpenStack manifests Feb 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2025 •
edited by openshift-ci bot
Loading

@EmilienM: This pull request references OSASINFRA-3600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM EmilienM changed the title OSASINFRA-3600: CARRY: OpenStack manifests OSASINFRA-3600: CARRY: OpenShift manifests Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@EmilienM: This pull request references OSASINFRA-3600 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Co-Authored-By: @mdbooth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM EmilienM mentioned this pull request Feb 7, 2025
Merged
@EmilienM
Copy link
Member Author

EmilienM commented Feb 7, 2025

/retest

@EmilienM
Copy link
Member Author

EmilienM commented Feb 10, 2025

/testwith openshift/cluster-api-provider-openstack/main/ci/prow/e2e-techpreview openshift/cluster-api-provider-openstack#352

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2025

@EmilienM, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: openshift/cluster-api-provider-openstack/main/ci/prow/e2e-techpreview

@EmilienM
Copy link
Member Author

EmilienM commented Feb 10, 2025

/testwith openshift/cluster-api-provider-openstack/main/e2e-techpreview openshift/cluster-api-provider-openstack#352

@EmilienM EmilienM mentioned this pull request Feb 10, 2025
Merged
@EmilienM EmilienM force-pushed the openshift branch 3 times, most recently from 38562d6 to b9940d7 Compare February 12, 2025 14:14
@EmilienM EmilienM changed the title OSASINFRA-3600: CARRY: OpenShift manifests OSASINFRA-3600: CARRY: OpenShift manifests & Makefile targets Feb 12, 2025
mdbooth
mdbooth reviewed Feb 12, 2025
View reviewed changes
mdbooth
mdbooth approved these changes Feb 12, 2025
View reviewed changes
Copy link

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tidy. I'm not able to usefully review the output in detail, but at the very least it provides a good base to iterate on.

@EmilienM EmilienM requested a review from mdbooth February 12, 2025 14:35
@EmilienM @mdbooth
CARRY: OpenStack manifests
a4c8c5d 
Co-Authored-By: Matthew Booth <[email protected]>
@mdbooth
Copy link

mdbooth commented Feb 12, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2025

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 32f8c5c into openshift:main Feb 12, 2025
6 checks passed
@EmilienM EmilienM deleted the openshift branch February 12, 2025 15:28
@openshift-bot
Copy link

openshift-bot commented Feb 12, 2025

[ART PR BUILD NOTIFIER]

Distgit: openstack-resource-controller
This PR has been included in build openstack-resource-controller-container-v4.19.0-202502122141.p0.g32f8c5c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkokkino dkokkino Awaiting requested review from dkokkino

@mandre mandre Awaiting requested review from mandre

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mdbooth mdbooth

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EmilienM @openshift-ci-robot @mdbooth @openshift-bot